Support multiple paths fallback in VaultBackend#70006
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:providers
area:secrets
kind:documentation
provider:hashicorp
eladkal
approved these changes
Jul 17, 2026
eladkal
left a comment
eladkal
left a comment
Contributor
There was a problem hiding this comment.
LGTM
might need @hussein-awala +1 as well
hussein-awala
left a comment
hussein-awala
left a comment
Member
There was a problem hiding this comment.
Since global_secrets_path is deprecated but not completely removed, could you add a test to ensure that there is no breaking change here?
Contributor
Author
|
Added test for that |
Contributor
|
Doc build is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#65493 introduced a global fallback for the VaultBackend. I suggest making this pattern more flexible by supporting a list of paths in the
connections_path/variables_path/config_path. For example:"connections_path": ["connections/prod", "connections/common", "connections/default"]In this PR I choose to keep the kwargs names
connections_path/variables_path/config_pathinstead of renaming to "paths" to avoid breaking changes. The PR does deprecateglobal_secrets_path. While that still exists, I decided to append it to all paths.Multi-team is still supported, so e.g. with
team="foobar"and"connections_path": ["connections/prod", "connections/common"], we'd check for the secret inconnections/prod/foobar/{secret}andconnections/common/foobar/{secret}.Was generative AI tooling used to co-author this PR?
Claude
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.